Cap the alignment of spilled values (vs. allocas) at the max frame alignment #3071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
aschwaighofer
force-pushed
the
coro_async_alignment_79664965
branch
from
52dea54 to
34c2353
Compare
|
@swift-ci test |
aschwaighofer
force-pushed
the
coro_async_alignment_79664965
branch
from
34c2353 to
3026438
Compare
|
@swift-ci Please test |
aschwaighofer
force-pushed
the
coro_async_alignment_79664965
branch
2 times, most recently
from
7438d49 to
3026438
Compare
… max frame alignment Before this patch we would normally use the ABI alignment which can be to high for the context alginment. For spilled values we don't need ABI alignment, since the frame entry's address is not escaped. rdar://79664965 Differential Revision: https://reviews.llvm.org/D105288
aschwaighofer
force-pushed
the
coro_async_alignment_79664965
branch
from
3026438 to
c575f28
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch we would normally use the ABI alignment which can be
to high for the context alginment.
For spilled values we don't need ABI alignment, since the frame entry's
address is not escaped.
rdar://79664965
https://reviews.llvm.org/D105288