Skip to content

[clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEn… #3079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

edymtt
Copy link

@edymtt edymtt commented Jul 8, 2021

…gine to allow diagnostics on target-unsupported options

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D104729

This code is necessary for building the next swift compiler on the next llvm.

(cherry picked from commit aaba371)

…gine to allow diagnostics on target-unsupported options

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D104729

(cherry picked from commit aaba371)
@edymtt edymtt requested a review from etcwilde July 8, 2021 16:57
@edymtt
Copy link
Author

edymtt commented Jul 8, 2021

@swift-ci please test

@edymtt edymtt requested a review from hyp July 8, 2021 16:58
@edymtt
Copy link
Author

edymtt commented Jul 8, 2021

@swift-ci please test Linux

@edymtt
Copy link
Author

edymtt commented Jul 8, 2021

Linux testing is hitting almost the same failures as #3074 (except LLVM :: CodeGen/AArch64/arm64e-ptrauth-invoke.ll)

15:36:34 1 warning(s) in tests
15:36:34 ********************
15:36:34 Failed Tests (17):
15:36:34   Clang :: Refactor/Extract/captured-variable-types.m
15:36:34   Clang :: Refactor/Extract/extract-objc-property.m
15:36:34   Clang :: Refactor/Extract/return-block.m
15:36:34   Clangd :: background-index.test
15:36:34   Clangd :: check-fail.test
15:36:34   Clangd :: check-lines.test
15:36:34   Clangd :: check.test
15:36:34   Clangd :: compile-commands-path-in-initialize.test
15:36:34   Clangd :: path-mappings.test
15:36:34   Clangd :: system-include-extractor.test
15:36:34   Clangd :: target_info.test
15:36:34   Clangd Unit Tests :: ./ClangdTests/DirectoryBasedGlobalCompilationDatabaseCacheTest.Cacheable
15:36:34   Clangd Unit Tests :: ./ClangdTests/GlobalCompilationDatabaseTest.BuildDir
15:36:34   Clangd Unit Tests :: ./ClangdTests/GlobalCompilationDatabaseTest.CompileFlagsDirectory
15:36:34   Clangd Unit Tests :: ./ClangdTests/GlobalCompilationDatabaseTest.Config
15:36:34   Clangd Unit Tests :: ./ClangdTests/GlobalCompilationDatabaseTest.DiscoveryWithNestedCDBs
15:36:34   Clangd Unit Tests :: ./ClangdTests/LSPTest.CDBConfigIntegration

Merging to allow Swift rebranch to build.

@edymtt edymtt merged commit a83a791 into swiftlang:apple/stable/20210628 Jul 8, 2021
@edymtt edymtt deleted the d104729-for-20210628 branch July 9, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants