[lldb] Call DestroyImpl for eStateInvalid #3112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The process ends up in eStateInvalid when you attempt to interrupt a GDBRemoteProcess and it doesn't return in time. When that happens we really should be calling Destroy because otherwise we might end up in a situation where we receive a packet while or after we've torn down the main process.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process ends up in eStateInvalid when you attempt to interrupt a
GDBRemoteProcess and it doesn't return in time. When that happens we
really should be calling Destroy because otherwise we might end up in a
situation where we receive a packet while or after we've torn down the
main process.