Add an API for clang dependency scanner to perform module lookup by name alone #3127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansvoboda11
requested changes
Jul 30, 2021
clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp
Outdated
Show resolved
Hide resolved
jansvoboda11
requested changes
Aug 16, 2021
clang/test/ClangScanDeps/Inputs/modules_cdb_clangcl_by_mod_name.json
Outdated
Show resolved
Hide resolved
…list of module and file dependencies of a module for a particular compiler invocation rdar://64538073
- Define a subclass of FrontendAction and call loadModule there. - Remove the API for creating a worker just for clang_experimental_DependencyScannerWorkerByModName_getFileDependencies_v1. - Add the capability to get the dependencies based on the module name to clang-scan-deps.
- Create a fake virtual source file instead of asking users to create one and pass it to the command line. - Remove the "translation-units" output from test case modules-full-by-mod-name.cpp. The information isn't useful as the source file name isn't passed on the command line in this case. - Inherit from `PreprocessOnlyAction`.
- Rebase. - Rename functions. - Remove unneeded test cases.
ahatanaka
force-pushed
the
PR-64538073-new
branch
from
dca1536 to
3d4d75e
Compare
clang/include/clang/Tooling/DependencyScanning/DependencyScanningWorker.h
Outdated
Show resolved
Hide resolved
clang/include/clang/Tooling/DependencyScanning/DependencyScanningWorker.h
Outdated
Show resolved
Hide resolved
clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp
Outdated
Show resolved
Hide resolved
- Remove member `ModuleName` and thread it through functions. Remove member `FakeMemBuffer` too and make it a variable inside `computeDependencies`. - Use `MemoryBufferRef` instead of `MemoryBuffer *`. - Use `StringRef` instead of `const char *`.
clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
Outdated
Show resolved
Hide resolved
- Use Optional<String> as the type of ModuleName. - Add comments explaining what happens if the passed ModuleName isn't empty.
jansvoboda11
approved these changes
Sep 2, 2021
|
LGTM, thanks for working through this Akira! @Bigcheese, @hyp, @dexonsmith do you have any additional feedback? |
dexonsmith
approved these changes
Sep 2, 2021
ahatanaka
changed the title
ahatanaka
changed the title
ahatanaka
added a commit
that referenced
this pull request
Sep 7, 2021
…ame alone (#3127) * [clang][clang-scan-deps] Add an experimental C API for returning the list of module and file dependencies of a module for a particular compiler invocation rdar://64538073 * Address review comments - Define a subclass of FrontendAction and call loadModule there. - Remove the API for creating a worker just for clang_experimental_DependencyScannerWorkerByModName_getFileDependencies_v1. - Add the capability to get the dependencies based on the module name to clang-scan-deps. * Address review comments - Create a fake virtual source file instead of asking users to create one and pass it to the command line. - Remove the "translation-units" output from test case modules-full-by-mod-name.cpp. The information isn't useful as the source file name isn't passed on the command line in this case. - Inherit from `PreprocessOnlyAction`. * Address review comments * Address review comments - Rebase. - Rename functions. - Remove unneeded test cases. * Address review comments - Remove member `ModuleName` and thread it through functions. Remove member `FakeMemBuffer` too and make it a variable inside `computeDependencies`. - Use `MemoryBufferRef` instead of `MemoryBuffer *`. - Use `StringRef` instead of `const char *`. * Address review comments - Use Optional<String> as the type of ModuleName. - Add comments explaining what happens if the passed ModuleName isn't empty. (cherry picked from commit 2a3e8df) Conflicts: clang/tools/libclang/libclang.map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase onto
nextbranch. The old pull request is here: #3099.