Support debugging Swift dylibs that were loaded after SwiftASTContext #3311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
kastiglione
approved these changes
Sep 30, 2021
| module_sp->GetFileSpec().GetPath().c_str()); | ||
| } | ||
| std::vector<std::string> module_names; | ||
| RegisterSectionModules(*module_sp, module_names); |
There was a problem hiding this comment.
Does this need to be done for all modules? Or would it be already done for most modules?
jimingham
approved these changes
Sep 30, 2021
| // We cannot reconfigure ClangImporter after its | ||
| // creation. Instead poison the SwiftASTContext so it gets | ||
| // recreated. | ||
| m_fatal_errors.SetErrorStringWithFormat( |
There was a problem hiding this comment.
Would it be worth adding an API on SwiftASTContext (ClearClangImporter or something) to do this? I worry that having a fatal error pending on the context could get you into trouble if some other subsystem checks for errors but isn't prepared to reconstitute the context.
There was a problem hiding this comment.
The only way to clear clangimporter is to create a new Swift compiler instance (= a new SwiftASTContext). The recreation is transparently handled by Target's GetScratchContext function.
… was initialized. This patch extends the ModulesDidLoad callback to register .swiftast sections in the new dylib and posons the context if necessary to force a reinitialization. rdar://81135636
adrian-prantl
force-pushed
the
81135636
branch
from
1856499 to
1348ae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… was initialized.
This patch extends the ModulesDidLoad callback to register .swiftast
sections in the new dylib and posons the context if necessary to force
a reinitialization.
rdar://81135636