Skip to content

Update CMakeLists.txt #3319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2021
Merged

Update CMakeLists.txt #3319

merged 1 commit into from
Oct 1, 2021

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Oct 1, 2021

Fix the python executable. The python interpreter is Python3_EXECUTABLE after the merge. We were relying on the shebang to get the python which could pick up the wrong version.

@compnerd
Update CMakeLists.txt
d013556 
Fix the python executable.  The python interpreter is `Python3_EXECUTABLE` after the merge.  We were relying on the shebang to get the python which could pick up the wrong version.
@compnerd
Copy link
Member Author

compnerd commented Oct 1, 2021

CC: @JDevlieghere @etcwilde @shahmishal

etcwilde
etcwilde approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM

@JDevlieghere JDevlieghere merged commit 4eb9dc6 into stable/20210726 Oct 1, 2021
@JDevlieghere JDevlieghere deleted the compnerd/20210726-python3 branch October 1, 2021 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etcwilde etcwilde etcwilde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@compnerd @etcwilde @JDevlieghere