Make the warmup of the SwiftASTContext cache lazy (NFC) #3324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparations for later refactorings. The (pointless) effect right now is that in 99% of the cases the cache warmup is now delayed until the ProcessModule loop. rdar://81717792
kastiglione
reviewed
Oct 5, 2021
| auto val_or_err = | ||
| module_sp->GetTypeSystemForLanguage(lldb::eLanguageTypeSwift); | ||
| if (!val_or_err) { | ||
| llvm::consumeError(val_or_err.takeError()); |
There was a problem hiding this comment.
what kind of errors might these be? I am wondering whether we should log these.
There was a problem hiding this comment.
If I read llvm::Expected<TypeSystem &> TypeSystemMap::GetTypeSystemForLanguage(lldb::LanguageType language, Module *module, bool can_create) { right, it never returns an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparations for later refactorings. The (pointless) effect
right now is that in 99% of the cases the cache warmup is now delayed
until the ProcessModule loop.
rdar://81717792