[lldb] Skip validation of simd types on typedef functions in tsstyperef #3337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
approved these changes
Oct 4, 2021
|
|
||
| // SIMD types have some special handling in the compiler, causing divergences | ||
| // on the way SwiftASTContext and TypeSystemSwiftTypeRef view the same type. | ||
| if (mangled_name.GetStringRef().contains_insensitive("simd")) |
There was a problem hiding this comment.
The string "simd" is really short and could appear in many types. Is there a way to use startswith() or at least search for "4simd" to make false positives slightly less likely? Otherwise this LGTM!
SIMD types have some special handling in the compiler, causing divergences on the way SwiftASTContext and TypeSystemSwiftTypeRef view the same type.
augusto2112
force-pushed
the
typedef-skip-simd-validation
branch
from
0d91791 to
9c6b8ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIMD types have some special handling in the compiler, causing divergences
on the way SwiftASTContext and TypeSystemSwiftTypeRef view the same type.