Skip to content

Avoid unconditionally calling into SwiftASTContext (NFC) #3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2021
Merged

Avoid unconditionally calling into SwiftASTContext (NFC) #3346

merged 1 commit into from
Oct 5, 2021

Conversation

adrian-prantl
Copy link

Because clearly this function is not yet complicated enough.

kastiglione
kastiglione reviewed Oct 5, 2021
View reviewed changes
Copy link

@kastiglione kastiglione left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is getting the number of children expensive?

@adrian-prantl
Copy link
Author

I'm working on making the creation of SwiftASTContext lazy. When that's done, the first call into SwiftASTContext will become very expensive.

@adrian-prantl adrian-prantl merged commit 1c18d12 into swiftlang:stable/20210726 Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kastiglione kastiglione kastiglione approved these changes

@augusto2112 augusto2112 Awaiting requested review from augusto2112

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrian-prantl @kastiglione