Fix nondeterminism in VALIDATE_AND_RETURN caused by comparing uniniti… #3351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kastiglione
reviewed
Oct 5, 2021
Comment on lines
+2493
to
+2500
| child_name = ""; | ||
| child_byte_size = 0; | ||
| child_byte_offset = 0; | ||
| child_bitfield_bit_size = 0; | ||
| child_bitfield_bit_offset = 0; | ||
| child_is_base_class = false; | ||
| child_is_deref_of_parent = false; | ||
| language_flags = 0; |
There was a problem hiding this comment.
Why are these reset here? If this is needed, it's missing a #ifndef NDEBUG
There was a problem hiding this comment.
It's because we'll validate them against their ast_* counterparts.
They are initialized unconditionally because the initialization has an effect outside of the function (these are passed in by reference), I really don't want to change LLDB's behavior in asserts/non-asserts build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…alized values