Revert "[modules] Fix miscompilation when using two RecordDecl definitions with the same name." #3369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions with the same name." This reverts commit 9454716. The patch being reverted results in swift-corelibs-foundation failing to build due to being unable to find `Glibc.pthread_mutex_t`. The declaration is defined in the module, but is also imported via CDispatch. This patch marks any complete redeclarations of a given declaration incomplete. Swift can't import incomplete declarations, so it is ignored in `ClangImporter::isVisibleFromModule`. We will need some mechanism of detecting redeclarations while not marking complete declarations as being incomplete.
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
@swift-ci please test macOS platform |
|
This has made it through the llvm bits of the macOS tests, I am feeling pretty confident in merging this. We will still be testing everything for the rebranch anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9454716.
The patch being reverted results in swift-corelibs-foundation failing to
build due to being unable to find
Glibc.pthread_mutex_t. Thedeclaration is defined in the module, but is also imported via
CDispatch. This patch marks any complete redeclarations of a given
declaration incomplete. Swift can't import incomplete declarations, so
it is ignored in
ClangImporter::isVisibleFromModule. We will need somemechanism of detecting redeclarations while not marking complete
declarations as being incomplete.
I'm going to revert this now so that we can continue making progress with the rebranch.
rdar://83990459