Skip to content

build: optionalize some clang resource headers #3491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

compnerd
Copy link
Member

This makes the RISCV specific resource header riscv_vector.h optional.
It also similarly treats some of the ARM NEON headers. The RISCV header
added 10 MB to the resource directory which was previously 10 MB. This
header is gratuitously large, and increases the size of the build for a
target which may not be enabled.

This makes the RISCV specific resource header `riscv_vector.h` optional.
It also similarly treats some of the ARM NEON headers.  The RISCV header
added 10 MB to the resource directory which was previously 10 MB.  This
header is gratuitously large, and increases the size of the build for a
target which may not be enabled.
@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Nov 1, 2021

CC: @hyp @etcwilde
I've sent this upstream as https://reviews.llvm.org/D112890 but I think that it is reasonable to apply this early as it should shave some of the build pressure we are experiencing after the merge.

@etcwilde
Copy link
Member

etcwilde commented Nov 1, 2021

LGTM

@etcwilde etcwilde merged commit bfd3cb1 into swiftlang:stable/20210726 Nov 1, 2021
@compnerd compnerd deleted the shave-riscv branch November 1, 2021 20:00
@compnerd
Copy link
Member Author

compnerd commented Nov 9, 2021

@ahatanaka - sure I can do that; do you have a run that you can point me to?

@ahatanaka
Copy link

You can reproduce this locally.

  1. check out stable/20210726.
  2. run cmake ../llvm -GNinja -DLLVM_TARGETS_TO_BUILD="X86" -DCMAKE_BUILD_TYPE=Debug -DLLVM_ENABLE_PROJECTS="clang" ... and build clang and llvm.
  3. run the CodeGen tests: llvm-lit -sv tools/clang/test/CodeGen.

I see 422 failed tests.

@ahatanaka
Copy link

Also make sure the build directory is cleaned before building clang and llvm.

@compnerd
Copy link
Member Author

@ahatanaka thanks! I've merged the changes for that into the 20210726 branch. Part of it is the version of the commit from upstream, and part of it was an auxiliary change that seems to differ from current upstream. I believe that should fix the issue that you are seeing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants