[lldb] Use reflection metadata to find the value type of an existential #3508
Conversation
|
Please test with following pull request: @swift-ci test |
| lldb::addr_t existential_address; | ||
| bool use_local_buffer = false; | ||
|
|
||
| if (in_value.GetValueType() == eValueTypeConstResult && |
There was a problem hiding this comment.
I think this could do with a few comments explaining what's happening here.
There was a problem hiding this comment.
For example, what does use_local_buffer mean?
| if (use_local_buffer) | ||
| PopLocalBuffer(); | ||
|
|
||
| if (maybe_is_inlined) { |
There was a problem hiding this comment.
It's a bit confusing because maybe_is_inlined is both a bool and an optional and both the value and wrapper behave like a bool, and the "maybe" sounds like it's part of the value rather than the wrapper. How about:
if (!is_inlined.HasValue()) {
// An error occurred, default to address.
return Value::ValueType::LoadAddress;
}
if (*is_inlined) {
// Inlined data, same as static data.
return static_value_type;
}
HasValue makes it more obvious that we are checking the optional container. What do you think?
augusto2112
force-pushed
the
find-value-type-refl
branch
from
46fd880 to
83a8378
Compare
|
Please test with following pull request: @swift-ci test |
|
@swift-ci test |
No description provided.