lldb: link swift's libswift to lldb #3537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (CMAKE_SYSTEM_NAME MATCHES "Darwin") | ||
| if(LIBSWIFT_BUILD_MODE MATCHES "HOSTTOOLS|.*HOSTLIBS") | ||
| target_link_directories(${target} PRIVATE | ||
| "${CMAKE_OSX_SYSROOT}/usr/lib/swift" |
There was a problem hiding this comment.
This line looks suspicious to me but I also don't fully understand what it does. Does this end up being in an rpath pointing into the build machine's SDK?
There was a problem hiding this comment.
For macOS: only in "bootstrapping" mode, which is only used for testing. For other modes the rpath is pointing to /usr/lib/swift.
For Linux: yes, but I couldn't figure out how to fix that. But this is already the case without this change.
|
@swift-ci test |
eeckstein
force-pushed
the
libswift-in-lldb
branch
from
f5294c1 to
f9353d3
Compare
|
@swift-ci test |
eeckstein
force-pushed
the
libswift-in-lldb
branch
from
f9353d3 to
a96da08
Compare
|
@swift-ci test |
This is needed for the swift expression parser once parts of the parser are implemented in swift.
eeckstein
force-pushed
the
libswift-in-lldb
branch
from
a96da08 to
56da298
Compare
|
@swift-ci test |
compnerd
added a commit
that referenced
this pull request
Jan 5, 2022
Fix the unified build; this should repair the CI: https://ci-external.swift.org/job/oss-swift-windows-toolchain-x86_64-vs2019/562/
eeckstein
added a commit
that referenced
this pull request
Jan 5, 2022
lldb: fix the build after #3537
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for the swift expression parser once parts of the parser are implemented in swift.
For details on libswift see https://github.com/apple/swift/blob/main/libswift/README.md.