[20210726] Allow __attribute__((swift_attr)) in attribute push pragmas #3547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beccadax
commented
Nov 17, 2021
This change does what it says on the tin: it allows SwiftAttr to be used with #pragma clang attribute push to add Swift attributes to large regions of header files. We plan to use this to annotate headers with concurrency information. Reviewed at https://reviews.llvm.org/D112773. Fixes rdar://83499885.
beccadax
force-pushed
the
send-me-an-object-stable
branch
from
1cea561 to
5d5d035
Compare
beccadax
changed the title
beccadax
changed the title
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does what it says on the tin: it allows
SwiftAttrto be used with#pragma clang attribute pushto add Swift attributes to large regions of header files. We plan to use this to annotate headers with concurrency information.Reviewed at https://reviews.llvm.org/D112773. Fixes rdar://83499885.