🍒/FBI/50b40b051890+f9e6be5cc1a2+10eb32f45d40+d09a21a0b378 #3573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve error handling for the lang objc tagged-pointer info. Rather than failing silently, report an error if we couldn't convert an argument to an address or resolve the class descriptor. (lldb) lang objc tagged-pointer info 0xbb6404c47a587764 error: could not get class descriptor for 0xbb6404c47a587764 (lldb) lang objc tagged-pointer info n1 error: could not convert 'n1' to a valid address Differential revision: https://reviews.llvm.org/D112945 (cherry picked from commit 50b40b0)
- Use formatv to print the addresses. - Add check for 0x0 which is treated as an invalid address. - Use a an address that's less likely to be interpreted as a real tagged pointer. (cherry picked from commit f9e6be5)
Don't try to get a class descriptor for a pointer that doesn't look like a tagged pointer. Also print addresses as fixed-width hex and update the test. (cherry picked from commit 10eb32f)
Somehow every pointer looks like it's tagged on GreenDragon. Removing the check to unblock the bot until we can get to the bottom of this. (cherry picked from commit d09a21a)
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
JDevlieghere
deleted the
🍒/FBI/50b40b051890+f9e6be5cc1a2+10eb32f45d40+d09a21a0b378
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lang objc tagged-pointer info