Headers: exclude #include_next <stdatomic.h> on MSVC
#3579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 14.31.30818 toolset has the following in the `stdatomic.h`: ~~~ #ifndef __cplusplus #error <stdatomic.h> is not yet supported when compiling as C, but this is planned for a future release. #endif ~~~ This results in clang failing to build existing code which relied on `stdatomic.h` in C mode on Windows. Simply fallback to the clang header until that header is available as a complete implementation. (cherry picked from commit 1ad7de9)
|
@swift-ci please test |
|
CC: @bnbarham |
|
Thanks for the cherry-pick @compnerd! I'm happy to merge this if it's needed for Windows, the test failures are all already known. |
|
Sounds good, let;s go ahead and merge this then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 14.31.30818 toolset has the following in the
stdatomic.h:This results in clang failing to build existing code which relied on
stdatomic.hin C mode on Windows. Simply fallback to the clang headeruntil that header is available as a complete implementation.
(cherry picked from commit 1ad7de9)