[lldb] Consider bound types when deciding if the overall type is dynamic #3581
Conversation
|
@swift-ci test |
| NodePointer type_list = node->getLastChild(); | ||
| if (type_list->getKind() != Node::Kind::TypeList) | ||
| return false; | ||
| for (size_t i = 0; i < type_list->getNumChildren(); ++i) { |
There was a problem hiding this comment.
for (NodePointer child : *type_list) {
lldb/test/Shell/SwiftREPL/Dict.test
Outdated
| @@ -7,19 +7,22 @@ | |||
| // once per element. | |||
|
|
|||
| [1:2, 2:3, 3:9] | |||
| // DICT-LABEL: $R0: [Int : Int] = 3 key/value pairs { | |||
| // DICT-LABEL: $R0: [Int : Int] = | |||
There was a problem hiding this comment.
I'm just curious: what does the full new output look like? Is the 3 key/value pairs on a different line now?
There was a problem hiding this comment.
Yes, the new output looks like this:
x: [Foundation.URL : Int] = {
_variant = {
object = {
rawValue = 2 key/value pairs {
[0] = {
key = "https://github.com"
value = 4
}
[1] = {
key = "https://apple.com"
value = 23
}
}
}
}
}
There was a problem hiding this comment.
Shouldn't the _variant = be hidden by the Dictionary data formatter? Is the formatter not triggering?
There was a problem hiding this comment.
@adrian-prantl an update on this: the changed isn't caused by this patch, but by implementing TypeSystemSwiftTypeRef::GetFullyUnqualifiedType, which this was in preparation for. I've removed the test changes and will look into why a typeref type ins't triggering the formatter.
augusto2112
force-pushed
the
tsstyperef-dynamic-add-struct
branch
from
cb1f8f5 to
248daba
Compare
|
@swift-ci test |
No description provided.