Plugins: repair the Windows build #3610
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in swiftlang#3590 introduced an undefined pure virtual method but did not mark it as a pure virtual method, resulting in an undefined exported function. The Windows build identified this issue. Patch by Adrian Prantl!
|
@swift-ci please test |
|
Is this a dupe of #3611? |
|
Yeah, it's a dupe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #3590 introduced an undefined pure virtual method but did
not mark it as a pure virtual method, resulting in an undefined exported
function. The Windows build identified this issue.
Patch by Adrian Prantl!
DO NOT FILE A PULL REQUEST
We are in the process of a github migration. Please do not create a pull request as this could interfere with the process.