Initialize the Swift CompilerInstance with the triple from the load commands. #3634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
adrian-prantl
force-pushed
the
triple
branch
2 times, most recently
from
5c75243 to
ed30e17
Compare
|
@swift-ci test |
keith
reviewed
Dec 7, 2021
kastiglione
reviewed
Dec 7, 2021
|
@swift-ci test |
kastiglione
reviewed
Dec 7, 2021
lldb/test/API/lang/swift/deployment_target/TestSwiftDeploymentTarget.py
Outdated
Show resolved
Hide resolved
kastiglione
reviewed
Dec 7, 2021
lldb/test/API/lang/swift/dwarfimporter/C/TestSwiftDWARFImporterC.py
Outdated
Show resolved
Hide resolved
|
@swift-ci test |
|
Looks like this breaks linux |
|
preset=lldb-pull-request |
|
preset=lldb-pull-request |
|
@JDevlieghere what am I doing wrong with the preset? |
|
@swift-ci test |
…ommands. The serialized triple is the triple of the last binary __swiftast section that was processed. Instead of relying on the section contents order, we overwrite the triple in the CompilerInvocation with the triple recovered from the binary.
|
preset=lldb-pull-request |
|
preset=lldb-pull-request |
I'm not sure, I thought this is how it's supposed to be used. I'm sure @shahmishal will know! |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The serialized triple is the triple of the last binary __swiftast
section that was processed. Instead of relying on the section contents
order, we overwrite the triple in the CompilerInvocation with the
triple recovered from the binary.
This should fix issues such as thew one reported in https://forums.swift.org/t/lldb-not-honoring-minimum-platform-version-for-spm-packages/53607