Skip to content

Implement a short-circuit case for Clang types in GetNumChildren(). #3651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

adrian-prantl
Copy link

This is avoids round-tripping the type through SwiftASTContext which
is both faster and more reliable.

rdar://86180838

@adrian-prantl
Copy link
Author

@swift-ci test

2 similar comments
@adrian-prantl
Copy link
Author

@swift-ci test

@adrian-prantl
Copy link
Author

@swift-ci test

@adrian-prantl
Copy link
Author

I don't understand why this PR got closed when I pushed.

@adrian-prantl adrian-prantl deleted the clang-num-children branch December 10, 2021 01:37
@adrian-prantl adrian-prantl restored the clang-num-children branch December 10, 2021 01:38
@adrian-prantl
Copy link
Author

I see. I accidentally pushed HEAD.

This is avoids round-tripping the type through SwiftASTContext which
is both faster and more reliable.

rdar://86180838
@adrian-prantl adrian-prantl reopened this Dec 10, 2021
@adrian-prantl
Copy link
Author

@swift-ci test

@adrian-prantl adrian-prantl merged commit 6572b9d into swiftlang:stable/20210726 Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant