[lldb] Bump macOS versions to 11 on the TestPlaygrounds test #3675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
augusto2112
force-pushed
the
sidestep-wrong-triple-gen
branch
from
b69fc7e to
9759e36
Compare
|
@swift-ci test |
adrian-prantl
requested changes
Dec 13, 2021
| @@ -17,7 +17,7 @@ let b = 5 | |||
|
|
|||
| a + b | |||
|
|
|||
| @available(macOS 10.11, iOS 8.0, tvOS 8.0, watchOS 6.0, *) func newAPI() -> Int { | |||
| @available(macOS 11.11, iOS 8.0, tvOS 8.0, watchOS 6.0, *) func newAPI() -> Int { | |||
There was a problem hiding this comment.
11.0 there has not (yet?) been an 11.11 :-)
| @@ -53,7 +53,7 @@ def get_build_triple(self): | |||
| version = '7.0' | |||
| triple = '{}-{}-{}{}'.format(arch, vendor, os, version) | |||
| else: | |||
| triple = '{}-apple-macosx10.10'.format(platform.machine()) | |||
| triple = '{}-apple-macosx11.10'.format(platform.machine()) | |||
This is necessary since macOS 11 was the first version to support ARM64, and the compiler will silently bump up the triple when something < 11 is specified.
augusto2112
force-pushed
the
sidestep-wrong-triple-gen
branch
from
9759e36 to
97da26f
Compare
|
@swift-ci test |
|
Thanks Augusto! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary since macOS 11 was the first version to support ARM64,
and the compiler will silently bump up the triple when something < 11 is
specified.