-
Notifications
You must be signed in to change notification settings - Fork 341
plugins: make swiftCompilerModules optional #3735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is not always available, and is definitely not yet available on Windows due to a completely broken build system. This optionalizes the dependency to repair the Windows build.
@swift-ci please test |
Why is this needed? |
Interesting, well, something is definitely not working as expected on the Swift side as I'm seeing a bunch of failures in CI: https://ci-external.swift.org/job/swift-PR-windows/19527/consoleText
|
ok, I'm fine with this change. Can you please add a comment that this is only a workaround for this problem on windows? |
Actually, it will fail without linking the stub, because it will need the |
Seems that there is a dependency issue between the two that causes this. How do you expect the dependency to flow for this? |
This is a bug: the initializeSwiftModules stub library is not added to the exported targets. The fix is here: swiftlang/swift#40712 |
Superseded by #3737. |
This is not always available, and is definitely not yet available on
Windows due to a completely broken build system. This optionalizes the
dependency to repair the Windows build.