[lldb] Make ReadCStringFromMemory default to read from the file-cache. #3856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test macOS |
Differential Revision: https://reviews.llvm.org/D118265 (cherry picked from commit b414954)
Now that reading C strings go through the file-cache by default, make sure that any calls that come from LLDBMemoryReader force live memory when we can't read from the file-cache. This is the case when: - The LLDB setting marks it as disabled. - The target is 32 bits (this may be subject to change). - The address we're reading from is not one of the fake addresses we resolved in LLDBMemoryReader.
augusto2112
force-pushed
the
read-cstrings-from-filecache-cherry-pick
branch
from
f25c176 to
03a0435
Compare
|
Besides the cherry-pick, I added a second commit so we don't read from the file-cache when we didn't resolve the address ourselves: |
|
@swift-ci test |
adrian-prantl
approved these changes
Feb 1, 2022
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: https://reviews.llvm.org/D118265
(cherry picked from commit b414954)