[lldb] Fix log messages in resolveRemoteAddress #3868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test Linux |
|
@swift-ci test |
kastiglione
changed the title
|
@swift-ci test |
augusto2112
reviewed
Feb 2, 2022
| "[MemoryReader] Could not make a real address out of file " | ||
| "address {1:x} and object file {}", | ||
| "[MemoryReader] Could not make a real address out of file address " | ||
| "{0:x} and object file {}", |
There was a problem hiding this comment.
Just tested this, {} will crash, change it to {1}
There was a problem hiding this comment.
The docs appear to indicate the index isn't required
There was a problem hiding this comment.
Weird, maybe it's a bug then? Or maybe if you specify one position you have to specify all of them?
There was a problem hiding this comment.
I wondered the same, in any case I'll stick with explicit indexes. None of the unit tests for formatv seem to use {}, so an index must be required.
There was a problem hiding this comment.
|
@swift-ci test |
augusto2112
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.