Remove eager propagation of SwiftASTContext warnings to Target. #3876
+3
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature is becoming less useful, as the per-module SwiftASTContexts are only being used as an emergency backup. The error messages are also available in the swift-healthcheck, so it's no longer the right trade-off to eagerly surface them. This is one of two loops in SwiftASTContext(ForExpression)::CreateInstance() that force-initializes all module SwiftASTContexts and we would like to get rid of both.
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is becoming less useful, as the per-module
SwiftASTContexts are only being used as an emergency backup. The error
messages are also available in the swift-healthcheck, so it's no
longer the right trade-off to eagerly surface them. This is one of two
loops in SwiftASTContext(ForExpression)::CreateInstance() that
force-initializes all module SwiftASTContexts and we would like to get
rid of both.