Skip to content

Test both new TagDecl flag and old miscompilation fix #3878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vsapsai
Copy link

@vsapsai vsapsai commented Feb 2, 2022

No description provided.

…declaration.

For redeclaration chains we maintain an invariant of having only a
single definition in the chain. In a single translation unit we make
sure not to create duplicates. But modules are separate translation
units and they can contain definitions for the same symbol
independently. When we load such modules together, we need to demote
duplicate definitions to keep the AST invariants.

Some AST clients are interested in distinguishing
declaration-that-was-demoted-from-definition and
declaration-that-was-never-a-definition. For that purpose introducing
`IsThisDeclarationADemotedDefinition`. No functional change intended.

rdar://80184238
(cherry picked from commit 09e785f)
…tions with the same name."

This reverts commit a0423cc.
@vsapsai
Copy link
Author

vsapsai commented Feb 2, 2022

Please test with following PR:
apple/llvm-project#3872

@swift-ci Please test

@vsapsai
Copy link
Author

vsapsai commented Feb 2, 2022

Noticed the link and link's text don't match and as I'm not sure which one CI is using, going to retest.

@vsapsai
Copy link
Author

vsapsai commented Feb 2, 2022

Please test with following PR:
swiftlang/swift#41144

@swift-ci Please test

1 similar comment
@vsapsai
Copy link
Author

vsapsai commented Feb 3, 2022

Please test with following PR:
swiftlang/swift#41144

@swift-ci Please test

@vsapsai vsapsai closed this Mar 11, 2022
@vsapsai vsapsai deleted the rdar80184238-demotion-and-reland-miscompilation-fix branch March 11, 2022 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant