Get SwiftASTContextForExpression's SDK path straight from debug info. #3879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
changed the title
This mostly-NFC patch cuts out the middle-person and directly parses the SDK info from the debug info in SwiftASTContextForExpression, rhus avoiding the costly need to iterate over all SwiftASTContext and the last call to warmup_contexts().
adrian-prantl
force-pushed
the
direct-sdk
branch
from
b5d1bbb to
9a713f9
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly-NFC patch cuts out the middle-person and directly parses
the SDK info from the debug info in SwiftASTContextForExpression, thus
avoiding the costly need to iterate over all SwiftASTContext and the
last call to warmup_contexts().