[lldb] Move resolvePointer code to resolvePointerAsSymbol and implement resolvePointer to map process addresses to tagged addressess #3882
Conversation
resolvePointerAsSymbol is executed before any memory read is done, so move the code that does this to it.
|
@swift-ci test |
If we read a real process address, try to map that back as a tagged LLDBMLLDBMemoryReader address, so further reads originating from it benefit from the file-cache optimization.
augusto2112
force-pushed
the
resolve-pointer-symbol
branch
from
74e5c48 to
3d63cec
Compare
|
This pull request has two commits: |
|
@swift-ci test |
|
|
||
| auto &target = m_process.GetTarget(); | ||
| Address addr; | ||
| if (!target.ResolveLoadAddress(readValue, addr)) { |
There was a problem hiding this comment.
So for an instance pointer pointing into the heap or stack, this is expected to fail, right?
There was a problem hiding this comment.
what happens with a pointer to global variable that would be in a non-const __DATA section?
There was a problem hiding this comment.
i.e, should there be a check that the address is in a read-only section?
There was a problem hiding this comment.
That shouldn't be necessary, because we only read from the file-cache if the section containing the address is read-only.
No description provided.