Skip to content

[lldb] Fix the formatting of data when logging. #3884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2022
Merged

[lldb] Fix the formatting of data when logging. #3884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lldb/source/Plugins/LanguageRuntime/Swift/LLDBMemoryReader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ bool LLDBMemoryReader::readBytes(swift::remote::RemoteAddress address,
stream.PutHex8(dest[i]);
stream.PutChar(' ');
}
return stream.GetData();
return std::string(stream.GetData());
};
LLDB_LOGV(log, "[MemoryReader] memory read returned data: {0}",
format_data(dest, size));
Expand Down Expand Up @@ -256,9 +256,9 @@ bool LLDBMemoryReader::readString(swift::remote::RemoteAddress address,
stream.PutHex8(c);
}
}
return stream.GetData();
return std::string(stream.GetData());
};
LLDB_LOGV(log, "[MemoryReader] memory read returned data: \"{0}\"",
LLDB_LOGV(log, "[MemoryReader] memory read returned string: \"{0}\"",
format_string(dest));
return true;
}
Expand Down