Eliminate unnecessary SwiftASTContext fallback in GetIndexOfChildMemb… #3889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erWithName(). Enums without payloads are not supposed to have children in the LLDB data formatter sense, so GetIndexOfChildMemberWithName should return 0. However previously we couldn't distinguish between SwiftLanguageRuntime failing to look up a type and a success where the match was a non-payload enum member.
|
@swift-ci test |
augusto2112
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erWithName().
Enums without payloads are not supposed to have children in the LLDB
data formatter sense, so GetIndexOfChildMemberWithName should return
0. However previously we couldn't distinguish between
SwiftLanguageRuntime failing to look up a type and a success where the
match was a non-payload enum member.