Skip to content

[lldb] Use readMetadataFromFileCacheEnabled to check if the file-cach… #3892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2022
Merged

[lldb] Use readMetadataFromFileCacheEnabled to check if the file-cach… #3892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lldb/source/Plugins/LanguageRuntime/Swift/LLDBMemoryReader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,9 @@ LLDBMemoryReader::resolvePointer(swift::remote::RemoteAddress address,
// from the file-cache optimization.
swift::remote::RemoteAbsolutePointer process_pointer("", readValue);

if (!readMetadataFromFileCacheEnabled())
return process_pointer;

auto &target = m_process.GetTarget();
Address addr;
if (!target.ResolveLoadAddress(readValue, addr)) {
Expand Down Expand Up @@ -395,7 +398,7 @@ llvm::Optional<Address>
LLDBMemoryReader::resolveRemoteAddress(uint64_t address) const {
Log *log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_TYPES));

if (!m_process.GetTarget().GetSwiftReadMetadataFromFileCache())
if (!readMetadataFromFileCacheEnabled())
return Address(address);

// If the address contains our mask, this is an image we registered.
Expand Down