Don't quote -target cmdline opt to TARGET_SWIFTFLAGS #3919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The double quote marks are preserved in this makefile setting, so the -target <triple> command line option & value are passed as a single word, which is not recognized by swiftc, when running the testsuite against environments where we need to specify the target value. Not normally used when running the testsuite on a native system.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't quote -target cmdline opt to TARGET_SWIFTFLAGS
The double quote marks are preserved in this makefile setting, so
the -target command line option & value are passed as a
single word, which is not recognized by swiftc, when running the
testsuite against environments where we need to specify the target
value. Not normally used when running the testsuite on a native
system.