[debug-info] If one sees a spill with a dbg.addr use, salvageDebugInfo upon it and don't hoist it. #3936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
adrian-prantl
approved these changes
Feb 11, 2022
…o upon it and don't hoist it. This ensures that if we have a dbg.addr in a coroutine funclet that is on one of our function arguments, that the dbg.addr is not mapped to undef and also that later it isn't hoisted to the front of the basic block. Instead it remains at its original cloned location. rdar://83957028 Differential Revision: https://reviews.llvm.org/D119576 (cherry picked from commit 19279ff) Conflicts: llvm/lib/Transforms/Coroutines/CoroFrame.cpp The conflict was that the upstream code here seems to handle more cases. I just did the same transform I did in OSS here (which is not hoisting llvm.dbg.addr). The rest of the code is unchanged.
|
Found a small error where we renamed something upstream. I am fixing it now. |
Upstreamed renamed a variable...
gottesmm
force-pushed
the
stable/20211026/coro-dbg.addr
branch
from
6f86016 to
6bd73c1
Compare
|
@swift-ci test |
gottesmm
commented
Feb 12, 2022
| // Salvage debug info on any dbg.addr that we see. We do not insert them | ||
| // into each block where we have a use though. | ||
| if (auto *DI = dyn_cast<DbgAddrIntrinsic>(U)) { | ||
| coro::salvageDebugInfo(DbgPtrAllocaCache, DI, Shape.ReuseFrameSlot); |
There was a problem hiding this comment.
ReuseFrameSlot is the variable that was renamed upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that if we have a dbg.addr in a coroutine funclet that is on one of
our function arguments, that the dbg.addr is not mapped to undef and also that
later it isn't hoisted to the front of the basic block. Instead it remains at
its original cloned location.
rdar://83957028
Differential Revision: https://reviews.llvm.org/D119576
(cherry picked from commit 19279ff)
Conflicts:
llvm/lib/Transforms/Coroutines/CoroFrame.cpp
The conflict was that the upstream code here seems to handle more cases. I just
did the same transform I did in OSS here (which is not hoisting llvm.dbg.addr).
The rest of the code is unchanged.