[lldb] Show --lldb-use-system-debugserver in readme #3957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimingham
reviewed
Feb 17, 2022
This is all from one build-script invocation. Would the build-script need to run that automatically then? |
I'm not sure what we prefer, but I will update the readme to mention the relationship between the flag and the script. |
|
That script creates the code signing cert which subsequent build will use. Until the cert expires, you don't need to run the command again.
… On Feb 16, 2022, at 7:14 PM, Andrew Trick ***@***.*** ***@***.***>> wrote:
I thought we preferred people run lldb/scripts/macos-setup-codesign.sh and then they can use the debugserver they built? Might at least mention that as an option.
This is all from one build-script invocation. Would the build-script need to run that automatically then?
—
Reply to this email directly, view it on GitHub <#3957 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUPVW65PQUW62K5MXAGXITU3RR2PANCNFSM5OTBUIOQ>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because your review was requested.
|
kastiglione
force-pushed
the
lldb-readme-use-system-debugserver
branch
from
ab33aaa to
fe638af
Compare
kastiglione
force-pushed
the
lldb-readme-use-system-debugserver
branch
from
fe638af to
db255e8
Compare
|
@swift-ci test |
|
@swift-ci test macOS |
kastiglione
added a commit
that referenced
this pull request
Mar 24, 2022
* [lldb] Show --lldb-use-system-debugserver in readme * Document macos-setup-codesign.sh * Improved wording of note (cherry picked from commit 0a2f1ba)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most people will likely want to build and test using the system debugserver.