[lldb] Read swift metadata from symbol rich binary #3960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
adrian-prantl
approved these changes
Feb 17, 2022
| @@ -10,6 +10,9 @@ let Definition = "target_experimental" in { | |||
| def SwiftUseReflectionSymbols : Property<"swift-use-reflection-symbols", "Boolean">, | |||
| Global, DefaultTrue, | |||
| Desc<"if true, optimize the loading of Swift reflection metadata by making use of available symbols.">; | |||
| def SwiftReadMetadataFromDSYM: Property<"swift-read-metadata-from-dsym", "Boolean">, | |||
There was a problem hiding this comment.
It's great that you made this switchable, but dsymutil only copies reflection metadata if the linker has stripped it, so there's little risk in pessimizing existing workflows with this feature.
| @@ -77,6 +87,10 @@ class LLDBMemoryReader : public swift::remote::MemoryReader { | |||
| /// module's virtual address space. | |||
| std::vector<std::pair<uint64_t, lldb::ModuleSP>> m_range_module_map; | |||
|
|
|||
| /// The set of modules where we should read memory from the symbol file's | |||
| /// object file instead of the main object file. | |||
| std::unordered_set<lldb::ModuleSP> m_modules_with_metadata_in_symbol_obj_file; | |||
There was a problem hiding this comment.
I would use an llvm::DenseSet<> but that's more out of habit.
augusto2112
force-pushed
the
read-from-dsym-obj-file
branch
3 times, most recently
from
7ad05b5 to
c41767a
Compare
|
@swift-ci test |
augusto2112
force-pushed
the
read-from-dsym-obj-file
branch
from
c41767a to
fd3b104
Compare
In cases where Swift metadata is present in the symbol rich binary, read swift metadata from it instead of from the main binary or the process. This patch essentially re-uses the functionality implemented to read metadata from the file-cache to achieve this.
augusto2112
force-pushed
the
read-from-dsym-obj-file
branch
from
fd3b104 to
983632d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where Swift metadata is present in the symbol rich binary, read
swift metadata from it instead of from the main binary or the process.
This patch essentially re-uses the functionality implemented to read
metadata from the file-cache to achieve this.