[lldb] Prevent IsSwiftMangledName false positives #3984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test Linux |
adrian-prantl
approved these changes
Feb 23, 2022
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test Linux |
|
@swift-ci test |
kastiglione
deleted the
lldb-Prevent-IsSwiftMangledName-false-positives
branch
kastiglione
added a commit
that referenced
this pull request
Mar 24, 2022
Some non-swift symbols can unintentionally cause `isSwiftSymbol` to return true. Any symbol starting with `_T` is considered a swift symbol because "old-style" mangling used this prefix. Prevent this by special casing `_T`-prefixed symbols. The only kind of old-style mangled that lldb should expect to see are ObjC class and protocol names. Classes use a `_TtC` or `_TtGC` prefix (the latter is for generics). Protocols are `_TtP`. (cherry picked from commit 06653e8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some non-swift symbols can unintentionally cause
isSwiftSymbolto return true. Any symbol starting with_Tis considered a swift symbol because "old-style" mangling used this prefix.Prevent this by special casing
_T-prefixed symbols. The only kind of old-style mangled that lldb should expect to see are ObjC class and protocol names. Classes use a_TtCor_TtGCprefix (the latter is for generics). Protocols are_TtP.