[move-function] Add tests that show that the debugger displays variables correctly given usage of the move function. #3986
Conversation
…les correctly given usage of the move function. These are the first end to end tests that validate that showing moved variables works correctly.
|
Waiting for swiftlang/swift#41523 to land. |
|
@swift-ci test |
|
|
||
| # We haven't defined varK yet. | ||
| varK = frame.FindVariable('k') | ||
| self.assertTrue(varK.value == None, "varK initialized too early?!") |
There was a problem hiding this comment.
thank you for the tests!
Note there are many specific assertion functions, including assertIsNone, assertEqual, assertGreater, etc. They help produce better error messages if a test does fail.
There was a problem hiding this comment.
Ok. I'll send a follow on commit. I also noticed an fr v that snuck in there that is not necessary.
There was a problem hiding this comment.
I don't want to create work, I mean only to mention it for future.
There was a problem hiding this comment.
@kastiglione I had other things I needed to do and it inspired me to port some tests.
| threads = lldbutil.get_threads_stopped_at_breakpoint( | ||
| self.process, self.breakpoints[0]) | ||
| self.assertTrue(len(threads) == 1) | ||
| self.thread = threads[0] |
There was a problem hiding this comment.
You might be able to achieve the same with
target, process, thread, bkpt = lldbutil.run_to_source_breakpoint(
self, 'stop here', lldb.SBFileSpec('main.swift'))
self.assertGreater(bkpt.GetNumLocations(), 6)
|
|
||
| # Go to the last breakpoint and make sure that k is reinitialized | ||
| # properly. | ||
| self.runCmd('continue') |
There was a problem hiding this comment.
if you store the process above, you could do process.Continue() here, which is slightly nicer than parsing a string command.
|
|
||
| # Go to breakpoint 3. k should no longer be valid. | ||
| self.runCmd('continue') | ||
| self.assertTrue(varK.value == None, "K is live but was moved?!") |
There was a problem hiding this comment.
self.assertEqual() will print the value the the comparison fails for easier debugging.
see lldb/third_party/Python/module/unittest2/unittest2/case.py for a full list
These are the first end to end tests that validate that showing moved variables
works correctly.
They work by just stepping through a program and validating the we can dump variables appropriately given their lifetimes.