[lldb] Remove string demangling from DemangleCanonicalType #4038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
kastiglione
commented
Mar 8, 2022
Comment on lines
+1825
to
+1831
| if (ContainsUnresolvedTypeAlias(canonical)) { | ||
| // If this is a typealias defined in the expression evaluator, | ||
| // then we don't have debug info to resolve it from. | ||
| CompilerType ast_type = | ||
| ReconstructType({this, opaque_type}).GetCanonicalType(); | ||
| canonical = GetCanonicalDemangleTree( | ||
| dem, ast_type.GetMangledTypeName().GetStringRef()); |
There was a problem hiding this comment.
this logic was inlined (copied) from GetCanonicalType in the same file.
There was a problem hiding this comment.
Should it be a static helper maybe?
augusto2112
approved these changes
Mar 8, 2022
adrian-prantl
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DemangleCanonicalTypehas been unnecessarily doing a round trip of mangling and then demangling. This change happened in #3358.When
GetCanonicalDemangleTreereturns a node tree without unresolved type aliases, the canonical type can be established directly from the node tree, without re-mangling and demangling.