🍒/austria/bfab18d86b27+5a27b99825a5+097d46f41c46+116715270d07+43374bee0e06+e618eb8727b0 #4043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDevlieghere
commented
Mar 9, 2022
JDevlieghere
commented
- [lldb] Remove "(i.e. ANSI)" from several property descriptions.
- [lldb] Show progress events in the command line driver
- [lldb] Add a setting to change the progress color
- [lldb] Always move the cursor back after printing progress
- [lldb] Undef GetMessage when including Windows.h
- [lldb] A few small changes to HandleProgressEvent
Addresses Adrian's feedback from D121062. (cherry picked from commit bfab18d)
This patch adds support for showing progress events when using lldb on the command line. It spawns a separate thread that listens for progress events and prints them to the debugger's output stream. It's nothing fancy (yet), for now it just prints the progress message. If we know the total number of items being processed, we prefix the message with something like [1/100], similar to ninja's output. This patch doesn't use any fancy terminal manipulation: it uses a simple carriage return (\r) to bring the cursor to the front of the line and vt100 escape codes to clear the (rest) of the line. Differential revision: https://reviews.llvm.org/D120972 (cherry picked from commit 5a27b99)
Add a setting to change how progress is shown in a color enabled terminal. This follows the existing -prefix, -suffix pattern that's used elsewhere in lldb. Differential revision: https://reviews.llvm.org/D121062 (cherry picked from commit 097d46f)
This got lost while iterating on the patch. We need to always move the cursor to the front of the line so that if something else (asynchronously) prints to the debugger's output it overwrites the progress message. (cherry picked from commit 1167152)
GetMessage is a define that can expand to GetMessageA (ANSI) or GetMessageW (wide). Avoid the issue when including this header by undef'ing the macro. (cherry picked from commit 43374be)
Of course I only noticed these things *after* landing the original patch... - Flush the output after clearing the line. - Move up the printing the carriage return to avoid duplication. - Use hexadecimal instead of octal for escape codes. (cherry picked from commit e618eb8)
|
@swift-ci please test |
No functional changes intended. (cherry picked from commit ad709bc)
We came to the conclusion that this doesn't matter for VSCode/Xcode because they don't use the default event loop and that other clients who might care should use the setting. Differential revision: https://reviews.llvm.org/D120972 (cherry picked from commit c24199e)
|
@swift-ci please test |
@swift-ci please test macos |
1 similar comment
@swift-ci please test macos |
JDevlieghere
deleted the
🍒/austria/bfab18d86b27+5a27b99825a5+097d46f41c46+116715270d07+43374bee0e06+e618eb8727b0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.