[lldb] Make leading $-prefix optional in swift demangle
#4054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test macOS Platform |
kastiglione
deleted the
lldb-Make-leading-prefix-optional-in-swift-demangle
branch
kastiglione
added a commit
that referenced
this pull request
Mar 24, 2022
Change `language swift demangle` to accept swift symbols that don't have a leading `$`. This matches the behavior of the command line `swift-demangle` tool (see [swift-demangle.cpp#L394-L396](https://github.com/apple/swift/blob/09cdd36c0ad480e68575db54e4b16fc47add46dc/tools/swift-demangle/swift-demangle.cpp#L394-L396)). This makes it more convenient to copy and paste symbols, because a double click on text doesn't select the `$`. While updating this command, I also replaced lldb's custom node tree printing function with Swift's `getNodeTreeAsString`. (cherry picked from commit 4facf96)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
language swift demangleto accept swift symbols that don't have a leading$. This matches the behavior of the command lineswift-demangletool (see swift-demangle.cpp#L394-L396).This makes it more convenient to copy and paste symbols, because a double click on text doesn't select the
$.While updating this command, I also replaced lldb's custom node tree printing function with Swift's
getNodeTreeAsString.