[lldb/Process] Silence toolchain mismatch warnings for Scripted Processes (NFC) #4067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
…sses (NFC) When using Scripted Processes, it's very likely that lldb's version might not align with the swift compiler that built the target. Thus, this will cause the toolchain mismatch warnings to be shown to the user every time they "stop" in a Swift frame. Since we shouldn't need Swift's AST to symbolicate the stopped stackframe, we can safely silence these warnings for Scripted Processes. Signed-off-by: Med Ismail Bennani <[email protected]>
…eads This patch pipes down the `-a|--load-all` crashlog command option to the Scripted Process initializer to load all the images used by crashed process instead of only loading the images related to the crashed thread. This allows us to recreate artificial frames also for the non-crashed scripted threads. rdar://90396265 Differential Revision: https://reviews.llvm.org/D121826 Signed-off-by: Med Ismail Bennani <[email protected]>
medismailben
force-pushed
the
silence-sp-warnings
branch
from
c086598 to
7d0dd1b
Compare
|
@swift-ci test |
JDevlieghere
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Scripted Processes, it's very likely that lldb's version
might not align with the swift compiler that built the target.
Thus, this will cause the toolchain mismatch warnings to be shown to the
user every time they "stop" in a Swift frame.
Since we shouldn't need Swift's AST to symbolicate the stopped stackframe,
we can safely silence these warnings for Scripted Processes.
This PR also introduces the ability to load all images used in a crashlog, which
allow the underlying Scripted Process to create artificial frames for non-crashed threads.
rdar://90396265
Signed-off-by: Med Ismail Bennani [email protected]