Skip to content

[lldb/Process] Silence toolchain mismatch warnings for Scripted Processes (NFC) #4068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lldb/source/Target/Process.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5912,6 +5912,14 @@ void Process::PrintWarningCantLoadSwiftModule(const Module &module,
}

void Process::PrintWarningToolchainMismatch(const SymbolContext &sc) {
if (GetTarget().GetProcessLaunchInfo().IsScriptedProcess())
// It's very likely that the debugger used to launch the ScriptedProcess
// will not match the compiler version used to build the target, and we
// shouldn't need Swift's serialized AST to symbolicate the frame where we
// stopped. However, because this is called from a generic place
// (Thread::FrameSelectedCallback), it's safe to silence the warning for
// Scripted Processes.
return;
if (!GetWarningsToolchainMismatch())
return;
if (!sc.module_sp || !sc.comp_unit)
Expand Down