Replace stack frame parameter with the more general process. (NFC) #4070
+37
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a completely NFC refactoring to replace the stack frame weak pointer passed through the LoadModule machinery with the less-specific lldb::ProcessSP that is actually needed in the end.
adrian-prantl
force-pushed
the
stackframe-process
branch
from
ab9e757 to
fd44c19
Compare
|
@swift-ci test |
augusto2112
approved these changes
Mar 15, 2022
kastiglione
reviewed
Mar 15, 2022
Comment on lines
+1324
to
+1325
| // FIXME: this is uninitialized! | ||
| lldb::ProcessSP process_sp; |
There was a problem hiding this comment.
is this intended to be fixed before merging?
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a completely NFC refactoring to replace the stack frame weak
pointer passed through the LoadModule machinery with the less-specific
lldb::ProcessSP that is actually needed in the end.