Link swift compiler modules to lldb #4071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to add an alias from wiftCompilerModules to swiftCompilerStub
This is needed for the swift expression parser once parts of the parser are implemented in swift.
add_library verifies that the target exists, so if swift isn't being built, or hasn't been configured yet, CMake complains. target_link_libraries doesn't care about the target at configure time. If the library doesn't exist come link-time, then we will see an error.
|
@swift-ci please test |
|
Failure: |
compnerd
approved these changes
Mar 15, 2022
|
The Windows toolchain test build is hitting a timeout while testing foundation. That is a separate issue than the one this is fixing, which would result in a configuration failure in lldb on Windows if done incorrectly. The Windows toolchain did get through lldb configuration, so I think it's okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-applies linking the swift compiler modules to lldb, but uses
target_link_librariesinstead of usingadd_libraryto create an alias.target_link_librariesdoesn't care if the libraries exist until link time,add_librarydoes. In a unified build, lldb is configured before Swift, so the target doesn't exist, which is why it was failing on Windows in the unified build.rdar://90236027