🍒/austria/d230848a85a922260b7ad6984f2dd19222c125a6+5e65e79bace6127da493de1445161f1179e4e47f+2fc38b2b7bf9896806749655124ea5f13cc6d383 #4080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDevlieghere
commented
Mar 16, 2022
JDevlieghere
commented
- [lldb] Print an error message when we're reading libobjc.A.dylib from memory
- [lldb] Move ProgressEventData out of debugger and into its own file (NFC)
- [lldb] Report debugger diagnostics as events
… memory Use libobjc.A.dylib as a sentinel to detect situations where we're reading libraries from process memory instead of the shared cache. Differential revision: https://reviews.llvm.org/D117623 (cherry picked from commit d230848)
…NFC) Move ProgressEventData out of debugger and into its own file. This is in preparation of adding a few new type of event data for diagnostics. Differential revision: https://reviews.llvm.org/D121506 (cherry picked from commit 5e65e79)
Report warnings and errors through events instead of printing directly the to the debugger's error stream. By using events, IDEs such as Xcode can report these issues in the UI instead of having them show up in the debugger console. The new diagnostic events are handled by the default event loop. If a diagnostic is reported while nobody is listening for the new event types, it is printed directly to the debugger's error stream. Differential revision: https://reviews.llvm.org/D121511 (cherry picked from commit 2fc38b2)
|
@swift-ci please test |
|
@swift-ci please test |
JDevlieghere
deleted the
🍒/austria/d230848a85a922260b7ad6984f2dd19222c125a6+5e65e79bace6127da493de1445161f1179e4e47f+2fc38b2b7bf9896806749655124ea5f13cc6d383
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.