Add more system paths to the reject list.

[adrian-prantl]

Some versions of macOS install frameworks in these places, but LLDB
should never import modules from there and instead prefer the SDK.

rdar://89836973

[adrian-prantl]

@swift-ci test

[adrian-prantl]

@swift-ci test

[adrian-prantl]

@swift-ci test

[adrian-prantl]

@swift-ci test

[adrian-prantl]

@swift-ci test

[adrian-prantl]

@swift-ci test macOS

[jimingham]

/Library/Developer seems like a fairly generic directory within /Library and /Library is where external packages are supposed to install their artifacts. If we have to block that out as well we have to, but it doesn't feel right.

[kastiglione]

Is /Library/Developer/PrivateFrameworks for external packages too? Or only system?

[adrian-prantl]

@swift-ci test macOS

[adrian-prantl]

One other thing to note is that this is only about additional auto-discovered framework paths. If the application was built with -F/Library/Developer.... the path would still be accessible.

[adrian-prantl]

Is /Library/Developer/PrivateFrameworks for external packages too? Or only system?

I was operating under the assumption that that is specifically a path reserved by the system.

I haven't seen us explicitly claim that. For instance we did add ~/Library/Developer but everything gets put in subdirectories of that (Xcode, CoreDevice, etc.) so it could coexist with other packages.

[jimingham]

Is /Library/Developer/PrivateFrameworks for external packages too? Or only system?

/Library is where external packages put their code. External packages are free to have PrivateFrameworks. Normally you would install just in /Library/Frameworks or /Library/PrivateFrameworks but it makes sense to cordon your package off from others (presumably why we are putting stuff in Developer...) and I don't think we've claimed Developer formally.

[jimingham]

One other thing to note is that this is only about additional auto-discovered framework paths. If the application was built with -F/Library/Developer.... the path would still be accessible.

Clients of a library wouldn't link directly to PrivateFrameworks, however. So for a client they will always link to a public framework, which would then link to the PrivateFramework, so I think PrivateFrameworks are primarily going to be auto-discovered ones, right?

[adrian-prantl]

I verified that with #4083 we don't actually need to remove this path, because it gets added at the end of the path list and the desired path comes before it.

[adrian-prantl]

@swift-ci test