Skip to content

🍒/austria/8e893dfed5f9+557a0e7b9668+8212b41b7b7d #4086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 17, 2022
Merged

🍒/austria/8e893dfed5f9+557a0e7b9668+8212b41b7b7d #4086

merged 4 commits into from
Mar 17, 2022

Conversation

JDevlieghere
Copy link

  • [lldb] Fix flakyness in Minidump/no-process-id.yaml
  • [lldb] Fix flakyness in command-disassemble-process.yaml
  • [lldb] Fix flakiness in command-disassemble-process.yaml (2/2)

@JDevlieghere
[lldb] Fix flakyness in Minidump/no-process-id.yaml
9c826de 
(cherry picked from commit 8e893df)
@JDevlieghere
[lldb] Fix flakyness in command-disassemble-process.yaml
229d69b 
(cherry picked from commit 557a0e7)
@JDevlieghere
[lldb] Fix flakiness in command-disassemble-process.yaml (2/2)
dac1e77 
I split up the test so we could stop redirecting stderr to stdout but I
forgot to include that part in the previous commit.

(cherry picked from commit 8212b41)
@JDevlieghere
Copy link
Author

@swift-ci please test

@JDevlieghere
[lldb] Migrate condition evaluation failure to ReportError
e8d31af 
Migrate to using ReportError to report a failure to evaluate a
watchpoint condition. I had already done so for the parallel code for
breakpoints.

In the process, I noticed that I accidentally regressed the error
reporting for breakpoint conditions by dropping the call to
GetDescription. This patch rectifies that and adds a test.

Because the call to GetDescription expects a Stream*, I also switches
from using a raw_string_ostream to a StreamString for both breakpoints
and watchpoints.

(cherry picked from commit d10c0c7)
@JDevlieghere
Copy link
Author

@swift-ci please test

1 similar comment
@JDevlieghere
Copy link
Author

@swift-ci please test

@JDevlieghere
Copy link
Author

@swift-ci please test macos

1 similar comment
@JDevlieghere
Copy link
Author

@swift-ci please test macos

@JDevlieghere JDevlieghere merged commit 305475e into stable/20211026 Mar 17, 2022
@JDevlieghere JDevlieghere deleted the 🍒/austria/8e893dfed5f9+557a0e7b9668+8212b41b7b7d branch March 17, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JDevlieghere