Guard against unsigned overflow. #4093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
kastiglione
reviewed
Mar 18, 2022
| @@ -233,6 +233,7 @@ bool LLDBMemoryReader::readBytes(swift::remote::RemoteAddress address, | |||
| if (m_local_buffer) { | |||
| auto addr = address.getAddressData(); | |||
| if (addr >= *m_local_buffer && | |||
| addr < *m_local_buffer + m_local_buffer_size && | |||
There was a problem hiding this comment.
for other reviewers, this is the non-formatting change
kastiglione
approved these changes
Mar 18, 2022
|
@swift-ci test linux |
|
@swift-ci test Linux |
|
Context: I've seen this crash on an Apple Silicon machine today — I'm sure the root cause is something else, but this check still is wrong. |
|
Note |
|
@swift-ci test |
If addr+size overflows (for example because addr is LLDB_INVALID_ADDRESS) then this check still succeeds because addr+size will be <= m_local_buffer + m_local_buffer_size).
|
@swift-ci test |
|
@swift-ci test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If addr+size overflows (for example because addr is
LLDB_INVALID_ADDRESS) then this check still succeeds because addr+size
will be <= m_local_buffer + m_local_buffer_size).