[lldb] Don't persist the LINKEDIT slide in the indirect symbol offset #4114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code increment the indirect symbol offset with the LINKEDIT slide every time ObjectFileMachO::ParseSymtab is called. This resulted in a crash when calling add-dsym which causes us to potentially re-parse the original binary's symbol table. There's a separate question about whether we should re-parse the symbol table at all which was fixed by D114288. Regardless, copying the load command is cheap enough that this is still the right thing to do. rdar://72337717 Differential revision: https://reviews.llvm.org/D122349 (cherry picked from commit b0dc2fa)
|
@swift-ci please test |
JDevlieghere
deleted the
🍒/austria/b0dc2fae602579114525353c8403d6e6d128ad73
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code increment the indirect symbol offset with the LINKEDIT
slide every time ObjectFileMachO::ParseSymtab is called.
This resulted in a crash when calling add-dsym which causes us to
potentially re-parse the original binary's symbol table. There's a
separate question about whether we should re-parse the symbol table at
all which was fixed by D114288. Regardless, copying the load command is
cheap enough that this is still the right thing to do.
rdar://72337717
Differential revision: https://reviews.llvm.org/D122349
(cherry picked from commit b0dc2fa)